rushilwiz/astute
1
0
Fork 0
mirror of https://github.com/dyiop/astute.git synced 2025-04-05 21:10:16 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

* Fixed Invoice Payment checks. Must be >= 0, can't be more than outstanding balance

Browse Source
This commit is contained in:
Gopi Katwala 2019-07-16 15:07:00 -04:00
parent 5b4e1f32bd
commit b897d2cc1b
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
AstuteSystem/src/main/java/com/astute/dao/SqlDAO.java
View File

@ -464,7 +464,7 @@ public class SqlDAO extends DAO {
public double getOutstandingBalance(String InvoiceNumber) throws AstuteException { public double getOutstandingBalance(String InvoiceNumber) throws AstuteException {
double balance; double balance;
try { try {
System.out.println("Calling delete_invoice DB function"); System.out.println("Calling get_outstanding_inv_balance DB function");
CallableStatement stmt = conn.prepareCall("{? = call get_outstanding_inv_balance(?)}"); CallableStatement stmt = conn.prepareCall("{? = call get_outstanding_inv_balance(?)}");
stmt.registerOutParameter(1, Types.VARCHAR); stmt.registerOutParameter(1, Types.VARCHAR);
stmt.setString(2, InvoiceNumber); stmt.setString(2, InvoiceNumber);
@ -1322,6 +1322,9 @@ public class SqlDAO extends DAO {
if (paymentAmount > getOutstandingBalance(invoiceNum) ) { if (paymentAmount > getOutstandingBalance(invoiceNum) ) {
throw new AstuteException(DB_ERROR,"Payment amount can't be greater than outstanding balance for Invoice " + invoiceNum); throw new AstuteException(DB_ERROR,"Payment amount can't be greater than outstanding balance for Invoice " + invoiceNum);
} }
if (paymentAmount <= 0) {
throw new AstuteException(DB_ERROR,"Payment amount must be greater than 0");
}
String dateString = "STR_TO_DATE('" + paymentDate + "', '%Y-%m-%d')"; String dateString = "STR_TO_DATE('" + paymentDate + "', '%Y-%m-%d')";
String sql = "insert into invoice_payment (inv_no, invoice_payment_type, invoice_amount, payment_date, check_no, transaction_no) values ('" + invoiceNum + "', " + invoicePaymentTypeId + ", " + paymentAmount + ", " + dateString + ", '" + checkNo +"', '" + transactionNo + "')"; String sql = "insert into invoice_payment (inv_no, invoice_payment_type, invoice_amount, payment_date, check_no, transaction_no) values ('" + invoiceNum + "', " + invoicePaymentTypeId + ", " + paymentAmount + ", " + dateString + ", '" + checkNo +"', '" + transactionNo + "')";
Statement stmt = conn.createStatement(); Statement stmt = conn.createStatement();