diff --git a/backend/services/resource.py b/backend/services/resource.py index fd6623c..67959c7 100644 --- a/backend/services/resource.py +++ b/backend/services/resource.py @@ -155,6 +155,6 @@ class ResourceService: entities = self._session.scalars(query).all() if not entities: - raise ResourceNotFoundException(f"No resource found with matching slug: {search_string}") + return [] return [entity.to_model() for entity in entities] \ No newline at end of file diff --git a/backend/test/services/resource_test.py b/backend/test/services/resource_test.py index 8ec8a9f..e93a6b3 100644 --- a/backend/test/services/resource_test.py +++ b/backend/test/services/resource_test.py @@ -106,14 +106,14 @@ def test_get_by_slug(resource_svc: ResourceService): def test_get_by_slug_not_found(resource_svc: ResourceService): """ Test getting a resource that does not exist """ slug = "Not Found" - with pytest.raises(ResourceNotFoundException): - resources = resource_svc.get_by_slug(user_test_data.admin, slug) - pytest.fail() + resources = resource_svc.get_by_slug(user_test_data.admin, slug) + assert len(resources) == 0 + assert resources == [] def test_get_by_slug_no_permission(resource_svc: ResourceService): """ Test getting a resource the user does not have access to """ slug = "Resource 2" - with pytest.raises(ResourceNotFoundException): - resources = resource_svc.get_by_slug(user_test_data.employee, slug) - pytest.fail() + resources = resource_svc.get_by_slug(user_test_data.employee, slug) + assert len(resources) == 0 + assert resources == [] \ No newline at end of file