Compare commits

..

1 Commits

Author SHA1 Message Date
Emma Foster
abb53cdb6e
Merge 8f9d8a522f into cb54c9829d 2024-10-29 19:43:21 -04:00
2 changed files with 7 additions and 7 deletions

View File

@ -155,6 +155,6 @@ class ResourceService:
entities = self._session.scalars(query).all() entities = self._session.scalars(query).all()
if not entities: if not entities:
return [] raise ResourceNotFoundException(f"No resource found with matching slug: {search_string}")
return [entity.to_model() for entity in entities] return [entity.to_model() for entity in entities]

View File

@ -106,14 +106,14 @@ def test_get_by_slug(resource_svc: ResourceService):
def test_get_by_slug_not_found(resource_svc: ResourceService): def test_get_by_slug_not_found(resource_svc: ResourceService):
""" Test getting a resource that does not exist """ """ Test getting a resource that does not exist """
slug = "Not Found" slug = "Not Found"
resources = resource_svc.get_by_slug(user_test_data.admin, slug) with pytest.raises(ResourceNotFoundException):
assert len(resources) == 0 resources = resource_svc.get_by_slug(user_test_data.admin, slug)
assert resources == [] pytest.fail()
def test_get_by_slug_no_permission(resource_svc: ResourceService): def test_get_by_slug_no_permission(resource_svc: ResourceService):
""" Test getting a resource the user does not have access to """ """ Test getting a resource the user does not have access to """
slug = "Resource 2" slug = "Resource 2"
resources = resource_svc.get_by_slug(user_test_data.employee, slug) with pytest.raises(ResourceNotFoundException):
assert len(resources) == 0 resources = resource_svc.get_by_slug(user_test_data.employee, slug)
assert resources == [] pytest.fail()