From 0999b0fc27ae9f2e18c044c027fe0820a0536bbc Mon Sep 17 00:00:00 2001
From: Michael Fatemi <myfatemi04@gmail.com>
Date: Tue, 13 Jul 2021 14:22:31 -0400
Subject: [PATCH] create Header component, fix Notifications

---
 src/components/App.tsx                        | 48 +------------------
 src/components/Carpool/Carpool.tsx            |  5 +-
 src/components/Header/Header.tsx              | 36 ++++++++++++++
 src/components/Notifications/Notification.tsx |  2 +-
 .../Notifications/Notifications.tsx           | 18 ++++---
 src/components/WheelShare.tsx                 | 12 +----
 src/components/hooks.ts                       | 14 +++++-
 7 files changed, 64 insertions(+), 71 deletions(-)
 create mode 100644 src/components/Header/Header.tsx

diff --git a/src/components/App.tsx b/src/components/App.tsx
index 4f96b62..6d9e16e 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -1,9 +1,6 @@
-import { CSSProperties, lazy, Suspense, useEffect, useState } from 'react';
+import { CSSProperties, lazy, Suspense } from 'react';
 import { BrowserRouter, Route, Switch } from 'react-router-dom';
-import { getReceivedInvitationsAndRequests } from './api';
 import { useMe } from './hooks';
-import Notifications from './Notifications/Notifications';
-import { IInvitation } from './types';
 import WheelShare from './WheelShare';
 import WheelShareLoggedOut from './WheelShareLoggedOut';
 
@@ -11,33 +8,6 @@ const Authenticator = lazy(() => import('./Authentication/Authenticator'));
 const Carpool = lazy(() => import('./Carpool/Carpool'));
 const Group = lazy(() => import('./Group'));
 
-const dummyNotificationData: IInvitation[] = [
-	{
-		user: {
-			id: 0,
-			name: 'Michael Fatemi',
-		},
-		carpool: {
-			id: 0,
-			name: 'Cross Country',
-		},
-		isRequest: true,
-		sentTime: new Date().toISOString(),
-	},
-	{
-		user: {
-			id: 1,
-			name: 'Joshua Hsueh',
-		},
-		carpool: {
-			id: 0,
-			name: 'TJ Lax',
-		},
-		isRequest: false,
-		sentTime: new Date().toISOString(),
-	},
-];
-
 const style: CSSProperties = {
 	display: 'flex',
 	flexDirection: 'column',
@@ -48,27 +18,11 @@ const style: CSSProperties = {
 	marginRight: 'auto',
 };
 
-function useNotifications() {
-	const [notifications, setNotifications] = useState(dummyNotificationData);
-
-	useEffect(() => {
-		getReceivedInvitationsAndRequests().then(setNotifications);
-	}, []);
-
-	return notifications;
-}
-
 export default function App() {
 	const user = useMe();
-	const notifications = useNotifications();
 	return (
 		<div style={{ padding: '1rem', maxWidth: '100vw' }}>
 			<div style={style}>
-				{notifications.length > 0 ? (
-					<Notifications notifications={notifications} />
-				) : (
-					<span>No notifications</span>
-				)}
 				<BrowserRouter>
 					<Switch>
 						<Route
diff --git a/src/components/Carpool/Carpool.tsx b/src/components/Carpool/Carpool.tsx
index c471ba4..77e6307 100644
--- a/src/components/Carpool/Carpool.tsx
+++ b/src/components/Carpool/Carpool.tsx
@@ -1,10 +1,10 @@
 import MailOutlineIcon from '@material-ui/icons/MailOutline';
 import PersonAddIcon from '@material-ui/icons/PersonAdd';
-import { createContext } from 'react';
-import { useCallback, useEffect, useState } from 'react';
+import { createContext, useCallback, useEffect, useState } from 'react';
 import { useParams } from 'react-router-dom';
 import { cancelCarpoolInvite, getCarpool, sendCarpoolInvite } from '../api';
 import { lightgrey } from '../colors';
+import Header from '../Header/Header';
 import { ICarpool } from '../types';
 import UIButton from '../UI/UIButton';
 import UISecondaryBox from '../UI/UISecondaryBox';
@@ -84,6 +84,7 @@ export default function Carpool() {
 
 	return (
 		<CarpoolContext.Provider value={{ carpool, sendInvite, cancelInvite }}>
+			<Header />
 			<UISecondaryBox style={{ width: '100%', alignItems: 'center' }}>
 				{carpool ? (
 					<>
diff --git a/src/components/Header/Header.tsx b/src/components/Header/Header.tsx
new file mode 100644
index 0000000..a41db6a
--- /dev/null
+++ b/src/components/Header/Header.tsx
@@ -0,0 +1,36 @@
+import logout from '../Authentication/logout';
+import { useMe, useNotifications } from '../hooks';
+import Notifications from '../Notifications/Notifications';
+import UIPressable from '../UI/UIPressable';
+import UIPrimaryTitle from '../UI/UIPrimaryTitle';
+
+export default function Header() {
+	const me = useMe();
+	const notifications = useNotifications();
+	return (
+		<div
+			style={{
+				marginBottom: '0.5rem',
+				display: 'flex',
+				flexDirection: 'column',
+				alignItems: 'center',
+			}}
+		>
+			<UIPrimaryTitle>WheelShare</UIPrimaryTitle>
+			{me ? (
+				<>
+					{me.name}
+					<UIPressable onClick={logout}>Log out</UIPressable>
+					<br />
+					{notifications.length > 0 ? (
+						<Notifications notifications={notifications} />
+					) : (
+						<span>No notifications</span>
+					)}
+				</>
+			) : (
+				<span>Log In</span>
+			)}
+		</div>
+	);
+}
diff --git a/src/components/Notifications/Notification.tsx b/src/components/Notifications/Notification.tsx
index 3893ab1..a10d538 100644
--- a/src/components/Notifications/Notification.tsx
+++ b/src/components/Notifications/Notification.tsx
@@ -36,7 +36,7 @@ export default function Notification({
 			) : (
 				<span> invited you to join </span>
 			)}
-			{notification.carpool.name + sentTime.toLocaleString()}
+			{notification.carpool.name + ' at ' + sentTime.toLocaleString()}
 			{notification.isRequest ? (
 				<div className="notification-buttons" style={{ display: 'flex' }}>
 					<UIButton onClick={acceptReq}>Accept</UIButton>
diff --git a/src/components/Notifications/Notifications.tsx b/src/components/Notifications/Notifications.tsx
index 773b58c..9e8ab9a 100644
--- a/src/components/Notifications/Notifications.tsx
+++ b/src/components/Notifications/Notifications.tsx
@@ -7,16 +7,14 @@ export default function Notifications({
 	notifications: IInvitation[];
 }) {
 	return (
-		<div className="notifications">
-			<div style={{ display: 'flex', flexDirection: 'column' }}>
-				<h3 style={{ marginBlockEnd: '0' }}>Notifications</h3>
-				{notifications.map((notification) => (
-					<Notification
-						notification={notification}
-						key={`${notification.user.id}:${notification.carpool.id}`}
-					/>
-				))}
-			</div>
+		<div style={{ display: 'flex', flexDirection: 'column' }}>
+			<h3 style={{ marginBlockEnd: '0' }}>Notifications</h3>
+			{notifications.map((notification) => (
+				<Notification
+					notification={notification}
+					key={`${notification.user.id}:${notification.carpool.id}`}
+				/>
+			))}
 		</div>
 	);
 }
diff --git a/src/components/WheelShare.tsx b/src/components/WheelShare.tsx
index d96e999..3f49195 100644
--- a/src/components/WheelShare.tsx
+++ b/src/components/WheelShare.tsx
@@ -1,19 +1,11 @@
-import logout from './Authentication/logout';
 import Events from './Events';
 import Groups from './Groups/Groups';
-import { useMe } from './hooks';
-import UIPressable from './UI/UIPressable';
-import UIPrimaryTitle from './UI/UIPrimaryTitle';
+import Header from './Header/Header';
 
 export default function WheelShare() {
-	const { name } = useMe()!;
-
 	return (
 		<>
-			<UIPrimaryTitle>WheelShare</UIPrimaryTitle>
-
-			{name}
-			<UIPressable onClick={logout}>Log out</UIPressable>
+			<Header />
 
 			<Groups />
 			<Events />
diff --git a/src/components/hooks.ts b/src/components/hooks.ts
index 7372eda..69a37a0 100644
--- a/src/components/hooks.ts
+++ b/src/components/hooks.ts
@@ -1,5 +1,17 @@
-import { useContext } from 'react';
+import { useContext, useEffect, useState } from 'react';
+import { getReceivedInvitationsAndRequests } from './api';
 import AuthenticationContext from './Authentication/AuthenticationContext';
+import { IInvitation } from './types';
 
 export const useAuth = () => useContext(AuthenticationContext);
 export const useMe = () => useAuth().user;
+
+export function useNotifications() {
+	const [notifications, setNotifications] = useState<IInvitation[]>([]);
+
+	useEffect(() => {
+		getReceivedInvitationsAndRequests().then(setNotifications);
+	}, []);
+
+	return notifications;
+}